fix: use subtree option in getAnimations #8325
Conversation
|
Thanks! If you have time, would be awesome if you could add an example to storybook with an exit animation on a child element of the popover so we can verify that it works. |
|
@devongovett |
| }}> | ||
| <style> | ||
| {` | ||
| .react-aria-Popover[data-exiting] .content, |
There was a problem hiding this comment.
This fixes the issue for Safari from what I can tell.
| .react-aria-Popover[data-exiting] .content, | |
| @starting-style { | |
| .react-aria-Popover .content { | |
| opacity: 0; | |
| } | |
| } | |
| .react-aria-Popover[data-exiting] .content, |
There was a problem hiding this comment.
@snowystinger
Thanks for the Safari testing!
I've added @starting-style to the Storybook example to address the enter animation issue in Safari. However, this is a CSS-level consideration that developers will need to handle in their own implementations when targeting Safari.
I'm not sure of the best way for React Aria to help developers discover this Safari-specific requirement.
There was a problem hiding this comment.
Yeah I don't think this should be necessary. data-entering should be enough. If it isn't working, then that's a bug we should investigate.
Closes #8174
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: